Skip to content

fix: use sh on path #2985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: use sh on path #2985

merged 1 commit into from
Aug 9, 2024

Conversation

stephen-huan
Copy link
Contributor

This reverts a change in 2dc2a54 that I believe is tangential to the issue that the commit addresses. This makes it more consistent with the default value of the 'shell' option and the rest of the file. Personally, I have a different sh on $PATH than /bin/sh (actually, I do not have /bin/sh at all), which is how I noticed the change.

vimtex/autoload/vimtex/jobs/neovim.vim

Lines 155 to 162 in 5ac62e0

function! s:neovim_unix_run(cmd) abort " {{{1
call system(['sh', '-c', a:cmd])
endfunction
" }}}1
function! s:neovim_unix_capture(cmd) abort " {{{1
return systemlist(['sh', '-c', a:cmd])
endfunction

vimtex/autoload/vimtex/jobs/vim.vim

Lines 182 to 185 in 5ac62e0

let s:shell = executable('sh')
\ ? 'sh'
\ : (executable('/usr/bin/sh')
\ ? '/usr/bin/sh' : '/bin/sh')

@lervag
Copy link
Owner

lervag commented Aug 9, 2024

Thanks, I agree that this seems an unintended side effect.

@lervag lervag merged commit 7f6817c into lervag:master Aug 9, 2024
@stephen-huan stephen-huan deleted the binsh branch August 9, 2024 07:47
@lervag lervag mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephen-huan @lervag