Accept /proc/diskstat metrics with extra fields. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernels 4.18+ append 4 additional fields to /proc/diskstat output, breaking the original code that uses Sscanln, expecting the device line to terminate after the 14th field.
|
Thank you! |
|
Thank you for the PR, glad to seeing this tool is useful for such seasoned DBA like you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernels 4.18+ append 4 additional fields to /proc/diskstat output (see https://www.kernel.org/doc/Documentation/ABI/testing/procfs-diskstats), breaking the original code assumption of 14th fields only that was enforced by Sscanln.
The one-liner has been tested with Linux 4.20.7 and 4.4.0.