-
-
Notifications
You must be signed in to change notification settings - Fork 230
Fix typo in translation files #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update corrects a consistent typographical error in localization string keys across multiple language resource files and a Swift UI component. The substring "broser" in keys related to browser configuration panels is replaced with the correct "browser". No changes are made to translation values, logic, or control flow. Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (19)
✅ Files skipped from review due to trivial changes (11)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /ta.lproj/Localizable.strings (1)
126-128
: Typo fix in browser configuration keys
Correctly updates the misspelled substring "broser" to "browser" in the panel title, prompt, and message keys.Please ensure the changelog is updated to document this localization key correction.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (19)
MeetingBar/Resources /Localization /cs.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /de.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /en.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /es.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /fr.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /he.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /hr.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /hu.lproj/Localizable.strings
(2 hunks)MeetingBar/Resources /Localization /it.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /ja.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /nb-NO.lproj/Localizable.strings
(2 hunks)MeetingBar/Resources /Localization /nl.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /pl.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /sk.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /ta.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /tr.lproj/Localizable.strings
(1 hunks)MeetingBar/Resources /Localization /uk.lproj/Localizable.strings
(1 hunks)MeetingBar/Views/Preferences/BrowserConfigView.swift
(1 hunks)
👮 Files not reviewed due to content moderation or server errors (5)
- MeetingBar/Resources /Localization /hu.lproj/Localizable.strings
- MeetingBar/Resources /Localization /de.lproj/Localizable.strings
- MeetingBar/Resources /Localization /nb-NO.lproj/Localizable.strings
- MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings
- MeetingBar/Resources /Localization /en.lproj/Localizable.strings
🔇 Additional comments (13)
MeetingBar/Views/Preferences/BrowserConfigView.swift (1)
209-211
:✅ Verification successful
Updated localization keys in Swift view
TheopenPanel
assignments now reference the correctedpreferences_configure_browsers_choose_browser_panel_*
keys. To ensure there are no lingering typos, please run the following check:
🏁 Script executed:
#!/bin/bash # Verify no residual 'choose_broser_panel' keys in the codebase rg -n "choose_broser_panel"Length of output: 27
No residual
choose_broser_panel
localization keys found
A ripgrep search (rg -n "choose_broser_panel"
) returned no matches, confirming that the correctedpreferences_configure_browsers_choose_browser_panel_*
keys are used exclusively.MeetingBar/Resources /Localization /it.lproj/Localizable.strings (1)
135-137
: Fix typo in browser configuration keys
The keys for the choose-browser panel have been updated from "broser" to "browser" to match the correct spelling.MeetingBar/Resources /Localization /sk.lproj/Localizable.strings (1)
193-195
: Correct browser configuration localization keys
Updates the misspelled "broser" to "browser" in the panel title, prompt, and message keys.MeetingBar/Resources /Localization /nl.lproj/Localizable.strings (1)
134-136
: Correct typo in configure browsers panel keys
Fixes the "broser" misspelling to "browser" for the panel title, prompt, and message entries.MeetingBar/Resources /Localization /tr.lproj/Localizable.strings (1)
105-107
: Fix misspelling in browser configuration keys
Corrects the substring "broser" to "browser" in the localization keys for the browser selection panel.MeetingBar/Resources /Localization /he.lproj/Localizable.strings (1)
93-95
:✅ Verification successful
Corrected typo in browser configuration keys
The localization keys have been updated from
"broser"
to"browser"
correctly and align with other languages’ resource files. Please ensure there are no remaining references to the old typo across the repository.
🏁 Script executed:
#!/bin/bash # Verify no remaining 'broser' occurrences in the codebase rg -n 'broser'Length of output: 14
Typo “broser” fully removed
Ranrg -n 'broser'
across the repository—no matches found.MeetingBar/Resources /Localization /ja.lproj/Localizable.strings (1)
142-144
: Fixed typo in browser configuration keysThe keys have been updated from
"choose_broser_panel"
to"choose_browser_panel"
as intended. Translations remain unchanged and consistent.MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1)
139-141
: Corrected typo in browser configuration keysLocalization keys now use
"browser"
instead of"broser"
. Spanish string values are accurate and unchanged.MeetingBar/Resources /Localization /uk.lproj/Localizable.strings (1)
136-138
: Fixed typo in browser configuration keysThe keys have been corrected to
"choose_browser_panel_*"
. Ukrainian translations remain correct.MeetingBar/Resources /Localization /hr.lproj/Localizable.strings (1)
135-137
: Corrected typo in browser configuration keysThe typo
"broser"
has been replaced with"browser"
in all three keys. Croatian translations unchanged.MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (1)
188-190
: Typo fix in browser configuration keys (French)
The localization keys have been updated from the misspelled"broser"
to the correct"browser"
. The French string values are unchanged and read appropriately in context.MeetingBar/Resources /Localization /cs.lproj/Localizable.strings (1)
192-194
: Typo fix in browser configuration keys (Czech)
The localization keys have been corrected from"broser"
to"browser"
. The Czech translations remain accurate and contextually consistent.MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)
135-137
: Typo fix in browser configuration keys (Polish)
Updated the keys to replace"broser"
with"browser"
. The Polish strings themselves are correct and fit the UI context.
@leits |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
=======================================
Coverage 15.72% 15.72%
=======================================
Files 34 34
Lines 5391 5391
Branches 2124 2124
=======================================
Hits 848 848
Misses 4503 4503
Partials 40 40 ☔ View full report in Codecov by Sentry. |
Thanks, all good! |
Status
IN DEVELOPMENT
Description
Fix typo like below.
Checklist
Steps to Test or Reproduce
Summary by CodeRabbit