Skip to content

Conversation

koxya
Copy link
Contributor

@koxya koxya commented Apr 30, 2025

Status

IN DEVELOPMENT

Description

Fix typo like below.

-broser
+browser

Checklist

Steps to Test or Reproduce

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a typo in browser configuration panel labels across all supported languages, ensuring the proper spelling of "browser" in preferences dialogs.
    • Improved consistency and accuracy of localization keys for browser selection panels in the preferences interface.

Copy link

coderabbitai bot commented Apr 30, 2025

Walkthrough

This update corrects a consistent typographical error in localization string keys across multiple language resource files and a Swift UI component. The substring "broser" in keys related to browser configuration panels is replaced with the correct "browser". No changes are made to translation values, logic, or control flow.

Changes

File(s) Change Summary
MeetingBar/Resources/Localization/cs.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Czech translations unchanged.
MeetingBar/Resources/Localization/de.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; German translations unchanged.
MeetingBar/Resources/Localization/en.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; English translations unchanged.
MeetingBar/Resources/Localization/es.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Spanish translations unchanged.
MeetingBar/Resources/Localization/fr.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; French translations unchanged.
MeetingBar/Resources/Localization/he.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Hebrew translations unchanged.
MeetingBar/Resources/Localization/hr.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Croatian translations unchanged.
MeetingBar/Resources/Localization/hu.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Hungarian translations unchanged.
MeetingBar/Resources/Localization/it.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Italian translations unchanged.
MeetingBar/Resources/Localization/ja.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Japanese translations unchanged.
MeetingBar/Resources/Localization/nb-NO.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Norwegian translations unchanged.
MeetingBar/Resources/Localization/nl.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Dutch translations unchanged.
MeetingBar/Resources/Localization/pl.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Polish translations unchanged.
MeetingBar/Resources/Localization/pt-BR.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Portuguese translations unchanged.
MeetingBar/Resources/Localization/sk.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Slovak translations unchanged.
MeetingBar/Resources/Localization/ta.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Tamil translations unchanged.
MeetingBar/Resources/Localization/tr.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Turkish translations unchanged.
MeetingBar/Resources/Localization/uk.lproj/Localizable.strings Fixed "broser" to "browser" in three browser configuration panel keys; Ukrainian translations unchanged.
MeetingBar/UI/Views/Preferences/BrowserConfigView.swift Updated localization key usage from "broser" to "browser" for browser panel UI text.

Poem

A hop and a skip, a typo's gone astray,
"Broser" becomes "browser"—hip hip hooray!
Across many tongues, now the keys are just right,
So panels and prompts look crisp and bright.
🐰✨
From every translation, a bunny’s delight—
Clean code and clear words, what a wonderful sight!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 7a6b03f and d42124c.

📒 Files selected for processing (19)
  • MeetingBar/Resources /Localization /cs.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /de.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /en.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /he.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /hr.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /hu.lproj/Localizable.strings (2 hunks)
  • MeetingBar/Resources /Localization /it.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /ja.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /nb-NO.lproj/Localizable.strings (2 hunks)
  • MeetingBar/Resources /Localization /nl.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /sk.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /ta.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /tr.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /uk.lproj/Localizable.strings (1 hunks)
  • MeetingBar/UI/Views/Preferences/BrowserConfigView.swift (1 hunks)
✅ Files skipped from review due to trivial changes (11)
  • MeetingBar/Resources /Localization /cs.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /es.lproj/Localizable.strings
  • MeetingBar/UI/Views/Preferences/BrowserConfigView.swift
  • MeetingBar/Resources /Localization /uk.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /it.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /he.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /ja.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /hr.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /tr.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /fr.lproj/Localizable.strings
🚧 Files skipped from review as they are similar to previous changes (8)
  • MeetingBar/Resources /Localization /nl.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /sk.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /de.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /ta.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /en.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /hu.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /nb-NO.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /pl.lproj/Localizable.strings
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Codacy Security Scan
  • GitHub Check: Tests
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

leits
leits previously approved these changes May 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 21, 2025
@leits leits marked this pull request as ready for review May 21, 2025 11:33
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 21, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /ta.lproj/Localizable.strings (1)

126-128: Typo fix in browser configuration keys
Correctly updates the misspelled substring "broser" to "browser" in the panel title, prompt, and message keys.

Please ensure the changelog is updated to document this localization key correction.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between c12dfb5 and 7a6b03f.

📒 Files selected for processing (19)
  • MeetingBar/Resources /Localization /cs.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /de.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /en.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /he.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /hr.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /hu.lproj/Localizable.strings (2 hunks)
  • MeetingBar/Resources /Localization /it.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /ja.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /nb-NO.lproj/Localizable.strings (2 hunks)
  • MeetingBar/Resources /Localization /nl.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /sk.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /ta.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /tr.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Resources /Localization /uk.lproj/Localizable.strings (1 hunks)
  • MeetingBar/Views/Preferences/BrowserConfigView.swift (1 hunks)
👮 Files not reviewed due to content moderation or server errors (5)
  • MeetingBar/Resources /Localization /hu.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /de.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /nb-NO.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /pt-BR.lproj/Localizable.strings
  • MeetingBar/Resources /Localization /en.lproj/Localizable.strings
🔇 Additional comments (13)
MeetingBar/Views/Preferences/BrowserConfigView.swift (1)

209-211:

✅ Verification successful

Updated localization keys in Swift view
The openPanel assignments now reference the corrected preferences_configure_browsers_choose_browser_panel_* keys. To ensure there are no lingering typos, please run the following check:


🏁 Script executed:

#!/bin/bash
# Verify no residual 'choose_broser_panel' keys in the codebase
rg -n "choose_broser_panel"

Length of output: 27


No residual choose_broser_panel localization keys found
A ripgrep search (rg -n "choose_broser_panel") returned no matches, confirming that the corrected preferences_configure_browsers_choose_browser_panel_* keys are used exclusively.

MeetingBar/Resources /Localization /it.lproj/Localizable.strings (1)

135-137: Fix typo in browser configuration keys
The keys for the choose-browser panel have been updated from "broser" to "browser" to match the correct spelling.

MeetingBar/Resources /Localization /sk.lproj/Localizable.strings (1)

193-195: Correct browser configuration localization keys
Updates the misspelled "broser" to "browser" in the panel title, prompt, and message keys.

MeetingBar/Resources /Localization /nl.lproj/Localizable.strings (1)

134-136: Correct typo in configure browsers panel keys
Fixes the "broser" misspelling to "browser" for the panel title, prompt, and message entries.

MeetingBar/Resources /Localization /tr.lproj/Localizable.strings (1)

105-107: Fix misspelling in browser configuration keys
Corrects the substring "broser" to "browser" in the localization keys for the browser selection panel.

MeetingBar/Resources /Localization /he.lproj/Localizable.strings (1)

93-95:

✅ Verification successful

Corrected typo in browser configuration keys

The localization keys have been updated from "broser" to "browser" correctly and align with other languages’ resource files. Please ensure there are no remaining references to the old typo across the repository.


🏁 Script executed:

#!/bin/bash
# Verify no remaining 'broser' occurrences in the codebase
rg -n 'broser'

Length of output: 14


Typo “broser” fully removed
Ran rg -n 'broser' across the repository—no matches found.

MeetingBar/Resources /Localization /ja.lproj/Localizable.strings (1)

142-144: Fixed typo in browser configuration keys

The keys have been updated from "choose_broser_panel" to "choose_browser_panel" as intended. Translations remain unchanged and consistent.

MeetingBar/Resources /Localization /es.lproj/Localizable.strings (1)

139-141: Corrected typo in browser configuration keys

Localization keys now use "browser" instead of "broser". Spanish string values are accurate and unchanged.

MeetingBar/Resources /Localization /uk.lproj/Localizable.strings (1)

136-138: Fixed typo in browser configuration keys

The keys have been corrected to "choose_browser_panel_*". Ukrainian translations remain correct.

MeetingBar/Resources /Localization /hr.lproj/Localizable.strings (1)

135-137: Corrected typo in browser configuration keys

The typo "broser" has been replaced with "browser" in all three keys. Croatian translations unchanged.

MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (1)

188-190: Typo fix in browser configuration keys (French)
The localization keys have been updated from the misspelled "broser" to the correct "browser". The French string values are unchanged and read appropriately in context.

MeetingBar/Resources /Localization /cs.lproj/Localizable.strings (1)

192-194: Typo fix in browser configuration keys (Czech)
The localization keys have been corrected from "broser" to "browser". The Czech translations remain accurate and contextually consistent.

MeetingBar/Resources /Localization /pl.lproj/Localizable.strings (1)

135-137: Typo fix in browser configuration keys (Polish)
Updated the keys to replace "broser" with "browser". The Polish strings themselves are correct and fit the UI context.

@koxya
Copy link
Contributor Author

koxya commented May 21, 2025

@leits
Please re-review because I resolved conflicts 🙏

@koxya koxya requested a review from leits May 21, 2025 13:41
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 15.72%. Comparing base (f2da21a) to head (d42124c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ngBar/UI/Views/Preferences/BrowserConfigView.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #819   +/-   ##
=======================================
  Coverage   15.72%   15.72%           
=======================================
  Files          34       34           
  Lines        5391     5391           
  Branches     2124     2124           
=======================================
  Hits          848      848           
  Misses       4503     4503           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leits
Copy link
Owner

leits commented May 21, 2025

Thanks, all good!

@leits leits merged commit f2dc776 into leits:master May 21, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants