Translations update from Hosted Weblate #815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (273 of 273 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/fr/
## Walkthrough
This change updates French, Japanese, and Korean localization strings in the MeetingBar application. The French update modifies an error title interjection and splits a description string into two lines. The Japanese update refines multiple strings for clarity, naturalness, and politeness, including error messages, button labels, and descriptions. The Korean update adds six new localization keys related to preference UI elements such as language selection and preference tabs. No code logic or control flow has been altered; only localized text content is affected.
## Changes
| File(s) | Change Summary |
|---------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------|
| MeetingBar/Resources/Localization/fr.lproj/Localizable.strings | Modified two French localization strings: updated error title interjection and split a description string into two lines. |
| MeetingBar/Resources/Localization/ja.lproj/Localizable.strings | Updated multiple Japanese localization strings to improve phrasing, clarity, and politeness, including error messages, labels, and descriptions. |
| MeetingBar/Resources/Localization/ko.lproj/Localizable.strings | Added six new Korean localization keys for preference UI elements: language label and preference tab titles (services, calendars, bookmarks, general, advanced). |
## Possibly related PRs
- leits/MeetingBar#813: Updates Japanese localization strings, similar in purpose as a localization update.
- leits/MeetingBar#788: Updates localization string files for another language, parallel to this PR's changes.
## Suggested labels
`size:XS`, `lgtm`
## Suggested reviewers
- leits
## Poem
> 🐇
> In French, the words now gently flow,
> "Aïe!" cries MeetingBar, when links won't go.
> Descriptions split, two lines appear,
> Making the meaning crystal clear.
> In Japanese too, phrases refined,
> Polite and smooth, with care aligned.
> And Korean tabs now join the dance,
> Preferences labeled at a glance!
> A hop, a skip, localization bright—
> MeetingBar speaks just right!
>📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (2)
106-106: Typographic consistency: use non‑breaking space before the exclamation mark
In French typography, exclamation marks should be preceded by a non‑breaking space (\u00A0). The new string should mirror other entries (e.g.,"Oups ! …").
Proposed diff:-"status_bar_error_link_missed_title" = "Aïe! Impossible de rejoindre la %@"; +"status_bar_error_link_missed_title" = "Aïe ! Impossible de rejoindre la %@";
277-277: Sentence capitalization after line break
Since you’ve introduced explicit\nbreaks, consider capitalizing the first word on each new line to maintain sentence structure when rendered. For example:-"preferences_general_meeting_bar_description" = "MeetingBar est une application à code source ouvert\ncréée par Andrii Leitsius 🇺🇦\nPour des réunions en ligne plus faciles et plus fluides"; +"preferences_general_meeting_bar_description" = "MeetingBar est une application à code source ouvert\nCréée par Andrii Leitsius 🇺🇦\nPour des réunions en ligne plus faciles et plus fluides";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MeetingBar/Resources /Localization /fr.lproj/Localizable.strings(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Tests
- GitHub Check: Codacy Security Scan
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (1)
106-106: Follow French typography conventions for exclamation spacing
The new string"status_bar_error_link_missed_title" = "Aïe! Impossible de rejoindre la %@";should use a non‑breaking space before the exclamation mark to match French typographic rules and stay consistent with other entries (e.g.,
"Oups ! …"). For example:-"status_bar_error_link_missed_title" = "Aïe! Impossible de rejoindre la %@"; +"status_bar_error_link_missed_title" = "Aïe ! Impossible de rejoindre la %@";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
MeetingBar/Resources /Localization /fr.lproj/Localizable.strings(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Tests
- GitHub Check: Codacy Security Scan
🔇 Additional comments (1)
MeetingBar/Resources /Localization /fr.lproj/Localizable.strings (1)
277-277: Confirm multi-line description renders as intended
The updated value"preferences_general_meeting_bar_description" = "MeetingBar est une application à code source ouvert\ncréée par Andrii Leitsius 🇺🇦\nPour des réunions en ligne plus faciles et plus fluides";introduces two
\nline breaks. Please verify in the app that this three‑line format displays correctly (no clipping or unintended extra spacing).
Currently translated at 92.3% (252 of 273 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ja/
Currently translated at 92.6% (253 of 273 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ja/
Currently translated at 7.3% (20 of 273 strings) Translation: MeetingBar/App Translate-URL: https://hosted.weblate.org/projects/meetingbar/app/ko/
leits
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translations update from Hosted Weblate for MeetingBar/App.
Current translation status:
Summary by CodeRabbit