Hotfix: missing windows update after command #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'm looking forward to this hotfix. 👍 |
|
I accidentally helped someone today 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So who wants more Windows update 😁
I checked the code and I think this code was triggered almost every time after a command from CommandPipe except for the commands called from
display_event_handler.rs(key combos).In this PR I'm not restoring that exact behavior. I am updating the windows systematically after any command no matter the origin (from pipe or from key binding) as suggested by @AethanFoot #472 (comment)
My reasoning is that it is better to have consistency across command handling. The commands triggered by
display_event_handler.rsare for when a key combo occurs while the ones triggered in the event loop are for when a command is received via the command pipe. It seems more predictable and consistent that they both behave the same: update the windows right after any command no matter which origin.