Skip to content

Do not perform commodity reduction when parsing a format directive #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

Do not perform commodity reduction when parsing a format directive #2206

merged 1 commit into from
Mar 3, 2023

Conversation

jwiegley
Copy link
Member

@jwiegley jwiegley commented Mar 2, 2023 •
edited
Loading

Fixes #2205

tbm
tbm approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@tbm tbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John! This test case, and another one I tried, works. I'll add those test cases.

@tbm tbm merged commit 87b6a1e into master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbm tbm tbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression when specifying format for commodity "h"
2 participants
@jwiegley @tbm