Skip to content

Use system FindPython if newer #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2020
Merged

Use system FindPython if newer #1909

merged 2 commits into from
May 18, 2020

Conversation

q3aiml
Copy link
Collaborator

@q3aiml q3aiml commented May 18, 2020

Avoid needing to keep our copy updated and only keep it as a fallback
for when system cmake is not new enough.

Closes #1893

q3aiml added 2 commits May 17, 2020 19:02
@q3aiml
use system FindPython if newer
7c2b91b 
Avoid needing to keep our copy updated and only keep it as a fallback
for when system cmake is not new enough.
@q3aiml
run demo.py with ctest
aa82d43 
Fix error from newer cmake/FindPython versions not printing internal
Python_EXECUTABLE variable.
@q3aiml q3aiml mentioned this pull request May 18, 2020
Closed
tbm
tbm approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@tbm tbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I like this approach more than the one in 1904.

@tbm tbm merged commit 92b6072 into ledger:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbm tbm tbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specifying Python version when running cmake
2 participants
@q3aiml @tbm