Fix auto xact posts not getting applied to account total durring journal parse #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
|
I wonder if this also fixes #543... |
Christoph-D
added a commit
to Christoph-D/ledger
that referenced
this pull request
Jun 9, 2018
This fixes issue ledger#1127. In my understanding, PR ledger#552 was meant to fix this, but was incomplete. Automated transactions did not show up in assertions, so accounts affected by automated transactions became untestable. This change fixes this by adding a flag to the account to tell it that there is a new posting, analogous to the behavior of finalize(). I dug up issue ledger#1127 too late to find that this is the same solution proposed by @tbm. Although I came up with this independently, credit goes to Martin Michlmayr (@tbm).
Christoph-D
added a commit
to Christoph-D/ledger
that referenced
this pull request
Jun 9, 2018
This fixes issue ledger#1127. In my understanding, PR ledger#552 was meant to fix this, but was incomplete. Without this patch, automated transactions are invisible to assertions. This patch fixes this by adding a flag to the account to tell it that there is a new posting, analogous to the behavior of finalize(). I dug up issue ledger#1127 too late to find that this is the same solution proposed by @tbm. Although I wrote this independently, credit goes to Martin Michlmayr (@tbm).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some open issues related to balance assertions and auto transactions.
Durring journal parse, the auto xact posts are added but not flagged as visited like normal posts. So when the balance assertion is calculated, the account amount does not include the auto xacts in the calculation.
Should fix #538, #525, and my own use case :)