Skip to content

use latin1 in case of mysql #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2017
Merged

use latin1 in case of mysql #84

merged 2 commits into from
Apr 19, 2017

Conversation

punchdrunker
Copy link
Contributor

this PR is for #83
I fixed migration error under the condition of using mysql and utf8.

Mysql2::Error: Specified key was too long; max key length is 767 bytes:
CREATE UNIQUE INDEX `read_marks_reader_readable_index`  ON `read_marks` (`reader_id`, `reader_type`, `readable_type`, `readable_id`)

@coveralls
Copy link

coveralls commented Apr 19, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 7cf752f on punchdrunker:work/use-latin1 into 186cfdc on ledermann:master.

@ledermann ledermann merged commit c41fac6 into ledermann:master Apr 19, 2017
@ledermann
Copy link
Owner

Thanks!

@punchdrunker punchdrunker deleted the work/use-latin1 branch April 19, 2017 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@punchdrunker @coveralls @ledermann