Skip to content

Conversation

AnnaR-prog
Copy link
Contributor

Fixes are done in the following:

  1. Retry condition when the quorum is not met
  2. Calculation of actualQuorumNeeded number after every Retry
  3. Error represented to the user after quorum is not met

1. Retry condition when the quorum is not met
2. Calculation of actualQuorumNeeded after every Retry
3. Error represented to the user after quorum is not met
Copy link

github-actions bot commented Aug 26, 2025

Test Results

2 556 tests  +6   2 554 ✅ +6   26m 31s ⏱️ -47s
  124 suites ±0       2 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 7d6e852. ± Comparison against base commit 8aebcdf.

♻️ This comment has been updated with latest results.

avitenzer
avitenzer previously approved these changes Aug 27, 2025
@nimrod-teich nimrod-teich merged commit 9335922 into main Aug 27, 2025
30 checks passed
@nimrod-teich nimrod-teich deleted the bug_fixes_parallel_relay_quorum branch August 27, 2025 14:24
Tomelia1999 added a commit that referenced this pull request Aug 31, 2025
commit 9335922
Author: AnnaR-prog <anna@magmadevs.com>
Date:   Wed Aug 27 17:24:15 2025 +0300

    fix: The following has been fixed in the quorum feature (#2057)

    * [bug fixes]: The following has been fixed in the quorum feature:
    1. Retry condition when the quorum is not met
    2. Calculation of actualQuorumNeeded after every Retry
    3. Error represented to the user after quorum is not met

    * fix: changes after CR
nimrod-teich added a commit that referenced this pull request Sep 2, 2025
* git ignore

* backup providers scripts

* adding backup-providers flag to config file

* tests and mock

* adding backup provider logic to csm

* adding comments to provider_optimizer file

* adding comments to WeightedChoice

* update backup_provider

* unify functions

* Squashed commit of the following:

commit 8aebcdf
Author: avitenzer <tenzer@clara.co.uk>
Date:   Wed Aug 20 16:20:42 2025 +0300

    feat: enhance error logging  (#2055)

    * enhance error logging in ResultsManager for better troubleshooting

    - Added detailed error logging for relay errors, including status code and provider trailer.

    * fixed an issue in the results manager

    * updated e2e error codes

    * solved issue in the tests

    * updated the allowedErrorList

commit b151e5a
Author: Yaroms <103432884+Yaroms@users.noreply.github.com>
Date:   Wed Aug 20 11:18:27 2025 +0300

    feat: Parralel relay quorum (#2050)

    * feat: allow multiple relays on launch

    * support sending in parallel

    * pr changes

    * add header

    * adding sorting to json files

    * addin sorted json for comparing

    * add flags

    * add params struct

    * making the quorum based on unique results and not just results amount

    * return user error if the headers are wrong

    * input checks

    * fix unitest
    if failed to canonicaljson, print error instead of skipping

    * fix tests with default values

    * allow canonical errors

    ---------

    Co-authored-by: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
    Co-authored-by: Yaroms <yaroms@lavanet.xyz>
    Co-authored-by: avitenzer <tenzer@clara.co.uk>

commit 377114f
Merge: 0b9ec6f fb59765
Author: Yaroms <103432884+Yaroms@users.noreply.github.com>
Date:   Tue Aug 12 14:31:36 2025 +0300

    Merge pull request #2054 from lavanet/hedera-spec

    feat: add hedera spec

commit fb59765
Author: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
Date:   Mon Aug 11 15:26:39 2025 +0300

    feat: add hedera spec

* lint

* remove cu vlidation for backup providers

* adding validations to backup providers' chain-id

* Squashed commit of the following:

commit 9335922
Author: AnnaR-prog <anna@magmadevs.com>
Date:   Wed Aug 27 17:24:15 2025 +0300

    fix: The following has been fixed in the quorum feature (#2057)

    * [bug fixes]: The following has been fixed in the quorum feature:
    1. Retry condition when the quorum is not met
    2. Calculation of actualQuorumNeeded after every Retry
    3. Error represented to the user after quorum is not met

    * fix: changes after CR

* unify 2 IFs into 1

* revert IFs unify

* unify 2 IFs into 1

---------

Co-authored-by: Nim Rod <nimrod.teich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants