Skip to content

Conversation

avitenzer
Copy link
Collaborator

  • Added detailed error logging for relay errors, including status code and provider trailer.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

- Added detailed error logging for relay errors, including status code and provider trailer.
Copy link

github-actions bot commented Aug 12, 2025

Test Results

2 550 tests  ±0   2 548 ✅ ±0   26m 22s ⏱️ - 1m 20s
  124 suites ±0       2 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 4d9d1a8. ± Comparison against base commit b151e5a.

♻️ This comment has been updated with latest results.

@avitenzer avitenzer changed the title enhance error logging in ResultsManager for better troubleshooting feat: enhance error logging Aug 12, 2025
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 12, 2025
@avitenzer avitenzer closed this Aug 12, 2025
@avitenzer avitenzer reopened this Aug 12, 2025
@nimrod-teich nimrod-teich merged commit 8aebcdf into main Aug 20, 2025
30 checks passed
@nimrod-teich nimrod-teich deleted the request-errors branch August 20, 2025 13:20
Tomelia1999 added a commit that referenced this pull request Aug 25, 2025
commit 8aebcdf
Author: avitenzer <tenzer@clara.co.uk>
Date:   Wed Aug 20 16:20:42 2025 +0300

    feat: enhance error logging  (#2055)

    * enhance error logging in ResultsManager for better troubleshooting

    - Added detailed error logging for relay errors, including status code and provider trailer.

    * fixed an issue in the results manager

    * updated e2e error codes

    * solved issue in the tests

    * updated the allowedErrorList

commit b151e5a
Author: Yaroms <103432884+Yaroms@users.noreply.github.com>
Date:   Wed Aug 20 11:18:27 2025 +0300

    feat: Parralel relay quorum (#2050)

    * feat: allow multiple relays on launch

    * support sending in parallel

    * pr changes

    * add header

    * adding sorting to json files

    * addin sorted json for comparing

    * add flags

    * add params struct

    * making the quorum based on unique results and not just results amount

    * return user error if the headers are wrong

    * input checks

    * fix unitest
    if failed to canonicaljson, print error instead of skipping

    * fix tests with default values

    * allow canonical errors

    ---------

    Co-authored-by: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
    Co-authored-by: Yaroms <yaroms@lavanet.xyz>
    Co-authored-by: avitenzer <tenzer@clara.co.uk>

commit 377114f
Merge: 0b9ec6f fb59765
Author: Yaroms <103432884+Yaroms@users.noreply.github.com>
Date:   Tue Aug 12 14:31:36 2025 +0300

    Merge pull request #2054 from lavanet/hedera-spec

    feat: add hedera spec

commit fb59765
Author: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
Date:   Mon Aug 11 15:26:39 2025 +0300

    feat: add hedera spec
nimrod-teich added a commit that referenced this pull request Sep 2, 2025
* git ignore

* backup providers scripts

* adding backup-providers flag to config file

* tests and mock

* adding backup provider logic to csm

* adding comments to provider_optimizer file

* adding comments to WeightedChoice

* update backup_provider

* unify functions

* Squashed commit of the following:

commit 8aebcdf
Author: avitenzer <tenzer@clara.co.uk>
Date:   Wed Aug 20 16:20:42 2025 +0300

    feat: enhance error logging  (#2055)

    * enhance error logging in ResultsManager for better troubleshooting

    - Added detailed error logging for relay errors, including status code and provider trailer.

    * fixed an issue in the results manager

    * updated e2e error codes

    * solved issue in the tests

    * updated the allowedErrorList

commit b151e5a
Author: Yaroms <103432884+Yaroms@users.noreply.github.com>
Date:   Wed Aug 20 11:18:27 2025 +0300

    feat: Parralel relay quorum (#2050)

    * feat: allow multiple relays on launch

    * support sending in parallel

    * pr changes

    * add header

    * adding sorting to json files

    * addin sorted json for comparing

    * add flags

    * add params struct

    * making the quorum based on unique results and not just results amount

    * return user error if the headers are wrong

    * input checks

    * fix unitest
    if failed to canonicaljson, print error instead of skipping

    * fix tests with default values

    * allow canonical errors

    ---------

    Co-authored-by: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
    Co-authored-by: Yaroms <yaroms@lavanet.xyz>
    Co-authored-by: avitenzer <tenzer@clara.co.uk>

commit 377114f
Merge: 0b9ec6f fb59765
Author: Yaroms <103432884+Yaroms@users.noreply.github.com>
Date:   Tue Aug 12 14:31:36 2025 +0300

    Merge pull request #2054 from lavanet/hedera-spec

    feat: add hedera spec

commit fb59765
Author: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
Date:   Mon Aug 11 15:26:39 2025 +0300

    feat: add hedera spec

* lint

* remove cu vlidation for backup providers

* adding validations to backup providers' chain-id

* Squashed commit of the following:

commit 9335922
Author: AnnaR-prog <anna@magmadevs.com>
Date:   Wed Aug 27 17:24:15 2025 +0300

    fix: The following has been fixed in the quorum feature (#2057)

    * [bug fixes]: The following has been fixed in the quorum feature:
    1. Retry condition when the quorum is not met
    2. Calculation of actualQuorumNeeded after every Retry
    3. Error represented to the user after quorum is not met

    * fix: changes after CR

* unify 2 IFs into 1

* revert IFs unify

* unify 2 IFs into 1

---------

Co-authored-by: Nim Rod <nimrod.teich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants