Skip to content

Conversation

nimrod-teich
Copy link
Contributor

  • Add Kafka client for sending relay metrics to external systems
  • Implement retry logic with exponential backoff for Kafka send failures
  • Add retry queue to handle persistent failures and prevent data loss
  • Add proper error handling and monitoring for Kafka connectivity issues
  • Integrate Kafka client into RPC consumer metrics pipeline
  • Add command-line flag --relay-kafka-address for Kafka configuration
  • Support Kafka topic configuration via --relay-kafka-topic flag
  • Add unit tests for Kafka client functionality
  • Update go.mod and go.sum with Kafka dependencies

This enables reliable delivery of relay metrics to Kafka for external monitoring and analytics, with robust error handling and retry mechanisms.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Jul 2, 2025

Test Results

2 534 tests  +10   2 532 ✅ +10   27m 31s ⏱️ -26s
  124 suites ± 0       2 💤 ± 0 
    7 files   ± 0       0 ❌ ± 0 

Results for commit 6069d05. ± Comparison against base commit 1b473f0.

♻️ This comment has been updated with latest results.

@nimrod-teich nimrod-teich force-pushed the relay-usage-to-kafka branch 2 times, most recently from 987621f to 1e6c5ef Compare July 2, 2025 12:41
- Add Kafka client for sending relay metrics to external systems
- Implement retry logic with exponential backoff for Kafka send failures
- Add retry queue to handle persistent failures and prevent data loss
- Add proper error handling and monitoring for Kafka connectivity issues
- Integrate Kafka client into RPC consumer metrics pipeline
- Add command-line flag --relay-kafka-address for Kafka configuration
- Support Kafka topic configuration via --relay-kafka-topic flag
- Add unit tests for Kafka client functionality
- Update go.mod and go.sum with Kafka dependencies

This enables reliable delivery of relay metrics to Kafka for external
monitoring and analytics, with robust error handling and retry mechanisms.
@nimrod-teich nimrod-teich force-pushed the relay-usage-to-kafka branch from 1e6c5ef to 950d5e6 Compare July 2, 2025 13:05
1. Remove unused functions.
2. Avoid potential memory leaks and race conditions.
@nimrod-teich nimrod-teich force-pushed the relay-usage-to-kafka branch from da2205f to 6069d05 Compare July 7, 2025 11:20
@nimrod-teich nimrod-teich requested a review from Yaroms July 7, 2025 11:22
@Yaroms Yaroms merged commit 656a236 into main Jul 8, 2025
48 of 49 checks passed
@Yaroms Yaroms deleted the relay-usage-to-kafka branch July 8, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants