Skip to content

Conversation

orensv
Copy link
Contributor

@orensv orensv commented Apr 27, 2025

Description

Closes: #XXXX

Since the consumer automatically supports APIs not mentioned in the spec, we can remove all APIs that have default settings. Only doing it for Lava Testnet spec for tests


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Apr 27, 2025

Test Results

2 523 tests   - 1   2 522 ✅  - 1   25m 12s ⏱️ - 1m 6s
  124 suites ±0       1 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 088e3c1. ± Comparison against base commit d9c887f.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestIsDefaultApi/non-default_api_-_AllowMissingApisByDefault_is_false
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestIsDefaultApi/non-default_api_-_BlockParsing_is_not_empty
github.com/lavanet/lava/v5/protocol/chainlib ‑ TestIsDefaultApi/non-default_api_-_BlockParsing_is_not_default

♻️ This comment has been updated with latest results.

@Yaroms Yaroms merged commit 165f8d5 into main May 14, 2025
31 checks passed
@Yaroms Yaroms deleted the chore-simplify-lava-spec branch May 14, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants