Add more heuristics for backwards JWT compat #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These additional heuristics help in case the calling application was correctly calssifying key usage, as this is another valid hitn of what the application intended. Invalid key usage would already cause failure, so this does not affect the countermeasures introduced but can avoid issues in older applications. Signed-off-by: Simo Sorce <simo@redhat.com>
|
This has been independently tested to resolve issues in FreeIPA where the change caused a failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional heuristics help in case the calling application was correctly calssifying key usage, as this is another valid hitn of what the application intended.
Invalid key usage would already cause failure, so this does not affect the countermeasures introduced but can avoid issues in older applications.