Skip to content

Implement line-ending switching #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

MinusGix
Copy link
Member

@MinusGix MinusGix commented Mar 7, 2024

  • Added an entry to CHANGELOG.md if this change could be valuable to users

This is a companion PR to lapce/floem#353, that pr has most of the commentary.
Fixes #3029 (todo: there's probably some general line ending switching issue)

Normalizing the file's newlines is done on saving of the file.
This adds a LF/CRLF button to the status bar.

(Once the other PR is merged, I'll have to update this PR's floem)

@MinusGix MinusGix added A-ui Area: UI rendering and interactions A-editor Area: editor, modal editing labels Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 5.96%. Comparing base (43b54d0) to head (7ecf708).
Report is 31 commits behind head on master.

Files Patch % Lines
lapce-app/src/status.rs 0.00% 36 Missing ⚠️
lapce-app/src/palette.rs 0.00% 29 Missing ⚠️
lapce-app/src/editor.rs 0.00% 27 Missing ⚠️
lapce-app/src/doc.rs 0.00% 3 Missing ⚠️
lapce-app/src/window_tab.rs 0.00% 3 Missing ⚠️
lapce-app/src/palette/kind.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3047      +/-   ##
=========================================
- Coverage    6.01%   5.96%   -0.05%     
=========================================
  Files         122     122              
  Lines       42703   43110     +407     
=========================================
+ Hits         2569    2572       +3     
- Misses      40134   40538     +404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzhou121 dzhou121 merged commit 70cee3b into lapce:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area: editor, modal editing A-ui Area: UI rendering and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRASH] Carrige return (followed by string) crashes Lapce
2 participants