Skip to content

Implement completion lens #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Implement completion lens #1968

merged 1 commit into from
Jan 12, 2023

Conversation

MinusGix
Copy link
Member

@MinusGix MinusGix commented Jan 12, 2023

  • Added an entry to CHANGELOG.md if this change could be valuable to users

Adds the ability to view the expansion from completion as phantom text where the cursor is.
(VSCode has this feature as well, under the name 'Suggestion Preview'.)

image
image
(Might be nice to make snippets mark the places in the completion lens)

  • This is disabled by default, since VSCode disables it by default. I could imagine enabling it by default, but since it is not typical it may be distracting for most users since they aren't used to it.
  • The completion lens would appear in multiple editor views of the same document. I don't think this is really a problem, and making it only appear in the active document would require some modification of the code to have some per-editorview document textlayouts?
  • Multiline completion items are cut off at the moment, because we don't have support for 'fake' lines in the document code

@MinusGix MinusGix added A-ui Area: UI rendering and interactions A-editor Area: editor, modal editing labels Jan 12, 2023
@dzhou121 dzhou121 merged commit 3ab5056 into lapce:master Jan 12, 2023
@panekj panekj added this to the Next release milestone Jan 12, 2023
@MinusGix MinusGix mentioned this pull request Jun 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area: editor, modal editing A-ui Area: UI rendering and interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants