Skip to content

去除 cli 选项中 --port 的简写 #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

去除 cli 选项中 --port 的简写 #453

merged 1 commit into from
Nov 5, 2024

Conversation

hide-in-code
Copy link
Contributor

candy命令行执行的时候, --port和--stun 的简写标识都为 -s,为了与上面的password相区别,这里建议使用 -P

如果提交不符合规范,请拒绝

@lanthora
Copy link
Owner

lanthora commented Nov 5, 2024

提交规范没有问题. port 简写成了 s 是一个错误,计划里是不打算给 port 提供简写的.你来去掉 port 的简写?

@lanthora
Copy link
Owner

lanthora commented Nov 5, 2024

rebase 一下 commit 吧,现在是两个

@hide-in-code
Copy link
Contributor Author

rebase 一下 commit 吧,现在是两个

我是通过github的web界面操作的,白天我无法使用公司电脑进行提交代码。能否关闭本次pr,并开辟新的pr进行提交?

@lanthora
Copy link
Owner

lanthora commented Nov 5, 2024

我来在你基础上改吧,你先不用管了

@lanthora lanthora changed the title 命令行选项标识重复修正 去除 cli 选项中 --port 的简写 Nov 5, 2024
@lanthora lanthora merged commit cc76861 into lanthora:master Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants