fix(prompts): escape json in getLangchainPrompt #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improved JSON handling in Langchain prompt conversion by escaping JSON curly braces and updating variable matching logic, with comprehensive tests added.
escapeJsonForLangchainmethod inpromptClients.tsto escape JSON curly braces while preserving Mustache variables._transformToLangchainVariablesto match only word characters.langfuse.prompts.spec.tsfor JSON escaping, including edge cases like nested JSON, mixed variables, and empty objects.package.jsonto includeyarnas the package manager.This description was created by
for 6889cd6. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Fixed JSON handling in Langchain prompt conversion by improving variable transformation logic to properly escape JSON curly braces while preserving Mustache template variables.
langfuse-core/src/prompts/promptClients.tsto addescapeJsonForLangchainmethod that correctly handles JSON structures in prompts\w+), making it more preciselangfuse-core/test/langfuse.prompts.spec.tscovering JSON escaping edge cases