Skip to content

chore: move dashboard queries to new AMTs #8308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Aug 6, 2025

Conversation

Steffen911
Copy link
Contributor

@Steffen911 Steffen911 commented Aug 5, 2025

Important

Refactor query execution by moving executeQuery to queryExecutor.ts and updating its usage across the codebase.

  • Query Execution Refactor:
    • Move executeQuery function to queryExecutor.ts.
    • Update imports to use new executeQuery location in dashboard-router.ts, index.ts, and multiple test files.
  • Behavior Changes:
    • executeQuery now handles trace table references using measureAndReturn.
    • Improved error handling and logging in dashboard-router.ts for query execution.
  • Testing:
    • Update tests in queryBuilder.servertest.ts, queryBuilderDashboards.servertest.ts, queryBuilderSQLI.servertest.ts, and dashboard-router-pivot-table.servertest.ts to use new executeQuery location.

This description was created by Ellipsis for 65e53da. You can customize this summary. It will automatically update as commits are pushed.

Steffen911 added 30 commits July 4, 2025 14:49
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. feat-dashboard labels Aug 5, 2025
Base automatically changed from steffen/lfe-5579-backfill-traces-amts to main August 5, 2025 14:21
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 5, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Aug 5, 2025
@Steffen911 Steffen911 enabled auto-merge August 6, 2025 13:42
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Aug 6, 2025
@Steffen911 Steffen911 added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit c23b226 Aug 6, 2025
28 checks passed
@Steffen911 Steffen911 deleted the steffen/lfe-5577-dashboard-queries-3 branch August 6, 2025 13:58
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Aug 6, 2025
zhengchubo pushed a commit to zhengchubo/langfuse-allin that referenced this pull request Aug 8, 2025
* chore: create background migrations for traces amt tables

* chore: add database migrations

* chore: move tests to use AMTs in one config

* chore: shift backfill from {} to map()

* chore: modify ingestion test timeouts

* chore: keep minDate updates tracked

* chore: remove android lib to save swap space

* chore: check disk space

* chore: check mnt usage

* chore: skip swap to check runner performance

* chore: add timestamp lines

* chore: handle deletions

* chore: update test cases

* chore: linting

* chore: allow opt-in creation for background migratoin record

* chore: update comparison query

* chore: concurrency config

* chore: update names

* chore: update names

* chore: update tiemout

* chore: add pre-query logs

* chore: refactor long running query into util function

* chore: refactor query exists checks

* chore: set correct tables for clustered configs

* chore: increase number of retries

* chore: extend logging

* chore: gracefully handle aborted query

* chore: handle errors during execution and raise them

* chore; skip in progress header updates

* Update migrateTracesToTracesAMTs.ts

* chore: use default clickhouse settings for ingestion

* chore: add trace_id index on traces_all_amt

* chore: update sorting behaviour of batchAction test

* chore: drop logger

* chore: update test

* chore: lint and renames

* chore: update test cases

* chore: patch score tests

* chore: add final for the checkTraceExists behaviour

* chore: remove background migration insert

* chore: move dashboard queries to new AMTs

* chore: make sure to replace all references to old traces table

* chore: revert replacement behaviour

* chore: formatting

* chore: typo

* chore: lint and refactor

* chore: update import path

* chore: patch test behaviour

* chore: remove outdated comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat-dashboard size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant