Skip to content

chore: migrate additional queries to traces amts #8249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 1, 2025

Conversation

Steffen911
Copy link
Contributor

@Steffen911 Steffen911 commented Jul 31, 2025

Important

Migrate queries to use traces_all_amt for improved performance and update related functions and documentation.

  • Behavior:
    • Migrate queries to use traces_all_amt instead of traces for better performance in observations.ts, scores.ts, and observations.ts in public-api.
    • Introduce measureAndReturn for query execution, handling both existing and new execution paths.
  • Functions:
    • Update getObservationsTableInternal, generateObservationsForPublicApi, getObservationsCountForPublicApi to use AMT logic.
    • Update _handleGenerateScoresForPublicApi, _handleGetScoresCountForPublicApi to use AMT logic.
  • Misc:
    • Update README.md to reflect changes in query handling and checklist for traces table access patterns.

This description was created by Ellipsis for 92a4a77. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 31, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 1, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Aug 1, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 1, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 1, 2025
@Steffen911 Steffen911 merged commit 90247ab into main Aug 1, 2025
26 of 28 checks passed
@Steffen911 Steffen911 deleted the steffen/lfe-5580-shift-more-trace-reads-to-amt branch August 1, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant