Skip to content

fix cobra annotation sharing bug #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix cobra annotation sharing bug #518

merged 2 commits into from
Jul 20, 2023

Conversation

thetechnocrat-dev
Copy link
Contributor

@thetechnocrat-dev thetechnocrat-dev commented Jul 18, 2023 •
edited
Loading

Having the same annotations variable in multiple cmd init() functions was causing annotations to always be empty when using the plex create cmd. This fixes that bug, which is needed to correctly tag metrics. I didn't notice this bug in my earlier PR because I only locally tested with the plex run command.

Running

./plex create -t ./tools/equibind.json -i ./testdata/binding/pdbbind_processed_size1 -a testxy -a testyx --autoRun=true

Yielded the following results in PSQL queries

Screenshot 2023-07-18 at 9 48 45 AM

@thetechnocrat-dev thetechnocrat-dev linked an issue Jul 18, 2023 that may be closed by this pull request
annotations only work for run command #514
Closed
@vercel
Copy link

vercel bot commented Jul 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 1:53pm

@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci July 18, 2023 13:51 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci July 18, 2023 13:52 — with GitHub Actions Inactive
acashmoney
acashmoney approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎣 🪙

@thetechnocrat-dev thetechnocrat-dev merged commit b9f68eb into main Jul 20, 2023
@thetechnocrat-dev thetechnocrat-dev deleted the 514-annotations-only-work-for-run-command branch July 20, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acashmoney acashmoney acashmoney approved these changes

@hevans66 hevans66 Awaiting requested review from hevans66

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

annotations only work for run command
2 participants
@thetechnocrat-dev @acashmoney