Adding XXH_NAMESPACE to CMake builds #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with CMake, lz4 compiles its own version of xxHash. This is not ideal since it disallows the simultaneous use of xxHash and lz4 in the same project without modifications in the build.
I'm using Conan as a package manager, and as soon as I use xxHash and lz4, I get linker issues because of multiple defined symbols (xxHash functions in lz4 and xxHash). Originally, I tried fixing this in #1254, but as stated by @t-mat it is better to use the preprocessor define
XXH_NAMESPACE. I have added the namespace definition by default to static and dynamic library builds when using CMake.