Skip to content

⚡ (Re)calculate incremental eval accumulator on StaticEvaluation when needed #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 10, 2025
Merged

⚡ (Re)calculate incremental eval accumulator on StaticEvaluation when needed #1353

merged 7 commits into from
Jan 10, 2025

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Jan 10, 2025 •
edited
Loading

This allows to keep having incremental eval after a king move, being that position right after the move the only one that isn't calculated incrementally.

Test  | eval/incremental-restore-incrementalEval-on-staticeval
Elo   | 3.67 +- 2.64 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=32MB
LLR   | 2.90 (-2.25, 2.89) [0.00, 3.00]
Games | 28134: +7997 -7700 =12437
Penta | [632, 3220, 6115, 3419, 681]
https://openbench.lynx-chess.com/test/1203/

@eduherminio eduherminio changed the base branch from main to eval/incremental-2 January 10, 2025 19:59
@eduherminio eduherminio changed the title ⚡ Recalculate _incrementalEvalAccumulator on StaticEvaluation ⚡ (Re)calculate incremental eval accumulator on StaticEvaluation when needed Jan 10, 2025
Base automatically changed from eval/incremental-2 to main January 10, 2025 20:01
@eduherminio eduherminio marked this pull request as ready for review January 10, 2025 22:57
@eduherminio eduherminio merged commit c084883 into main Jan 10, 2025
27 checks passed
@eduherminio eduherminio deleted the eval/incremental-restore-incrementalEval-on-staticeval branch January 10, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eduherminio