Skip to content

🔍 Make TranspositionTableElement.Key an ushort instead of a short #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

🔍 Make TranspositionTableElement.Key an ushort instead of a short #1070

merged 1 commit into from
Oct 2, 2024

Conversation

eduherminio
Copy link
Member

@eduherminio eduherminio commented Oct 2, 2024 •
edited
Loading

This might prevent information loss or the attempt to use the wrong TT entries, given how (short)n can be -1 instead of the intended value it'd have with (ushort)n.

Test  | tt-key-ushort
Elo   | 4.68 +- 5.09 (95%)
SPRT  | 8.0+0.08s Threads=1 Hash=4MB
LLR   | 2.93 (-2.25, 2.89) [-5.00, 0.00]
Games | 7130: +2036 -1940 =3154
Penta | [144, 772, 1662, 818, 169]
https://openbench.lynx-chess.com/test/799/

@eduherminio eduherminio changed the title 🔍 Make TranspositionTableElement.Key an ushort instead of a short. 🔍 Make TranspositionTableElement.Key an ushort instead of a short Oct 2, 2024
@eduherminio eduherminio marked this pull request as ready for review October 2, 2024 01:21
@eduherminio eduherminio merged commit 3226221 into main Oct 2, 2024
27 checks passed
@eduherminio eduherminio deleted the tt-key-ushort branch October 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eduherminio