Skip to content

Add generated documentation for network zones #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2024
Merged

Add generated documentation for network zones #847

merged 3 commits into from
May 6, 2024

Conversation

rpunjani
Copy link
Contributor

@rpunjani rpunjani commented May 6, 2024

Resolves #821.

@rpunjani rpunjani requested a review from stgraber as a code owner May 6, 2024 20:43
@github-actions github-actions bot added the Documentation Documentation needs updating label May 6, 2024
@rpunjani rpunjani changed the title Issue 821 #821 - Add generated documentation for network zones May 6, 2024
@stgraber
Copy link
Member

stgraber commented May 6, 2024

Looking into this one now

rpunjani added 2 commits May 6, 2024 17:25
@rpunjani @stgraber
incusd/network/zone: add gendoc for network zone
cb40017 
Signed-off-by: Rohit Punjani <sunnyali1230@gmail.com>
@rpunjani @stgraber
doc: Update configs
135176c 
Signed-off-by: Rohit Punjani <sunnyali1230@gmail.com>
@rpunjani @stgraber
doc: Use gen doc for network zones
8307649 
Signed-off-by: Rohit Punjani <sunnyali1230@gmail.com>
@stgraber stgraber changed the title #821 - Add generated documentation for network zones Add generated documentation for network zones May 6, 2024
@stgraber
Copy link
Member

stgraber commented May 6, 2024

I did:

  • Moved everything to a single common group to simplify the include
  • Ran make static-analysis to make sure everything is clean
  • Ran make doc and make doc-serve to validate the result

@stgraber stgraber merged commit 94fcc7e into lxc:main May 6, 2024
This was referenced Mar 17, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

Assignees
No one assigned
Labels
Documentation Documentation needs updating
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add generated documentation for network zones
2 participants
@rpunjani @stgraber