Skip to content

Conversation

bensmrs
Copy link
Contributor

@bensmrs bensmrs commented Aug 8, 2025

Bugs solved:

Additional actions:

  • Remove pre-boot virtiofs logic
  • Remove dual virtiofs+9p logic, enforcing a single mount type
  • Make the agent a little dumber on path mounts (removing a virtiofs dmesg error when mounting 9p-only shares)

Future directions (to discuss here):

  • Maybe add more intelligence to disable virtiofs if image.os and related keys match a house-tailored heuristic?
  • Clarify FSType=9p into FSType=share or something like that?
  • (more globally) Actually restrict the user / non-internal server operations from setting some volatile keys? (some volatile keys should IMO still be settable by the user, like hwaddr)

That was a tough one to do, I tried to split the commits into easily reviewable ones, although some still are pretty big.

bensmrs added 4 commits August 8, 2025 12:50
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
@bensmrs bensmrs requested a review from stgraber as a code owner August 8, 2025 15:02
@github-actions github-actions bot added the Documentation Documentation needs updating label Aug 8, 2025
bensmrs added 2 commits August 8, 2025 21:12
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
bensmrs added 5 commits August 8, 2025 21:12
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
…actor 9p logic

Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
@stgraber stgraber merged commit a6a9f95 into lxc:main Aug 9, 2025
136 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Development

Successfully merging this pull request may close these issues.

Directory mounts declared before boot cannot be hot-detached on VMs
2 participants