incusd/dev_incus: Add extra validation for monitor #2285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't just rely on the process name but also make sure that it's running outside of the container as this is a unique characteristic of the real monitor process. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
hallyn
approved these changes
Jul 17, 2025
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Jul 17, 2025
…Incus) (#16047) When a process inside a container accesses `/dev/lxd` LXD will now check the `NSpid` status variable of each candidate monitor process to confirm the process has no PIDs in other namespaces. If it does then it can't be the LXC monitor process, even if it has "[lxc monitor]" in its process name. Inspired by ideas from lxc/incus#2285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't just rely on the process name but also make sure that it's running outside of the container as this is a unique characteristic of the real monitor process.