Ensure usage of server address from the join request #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided server address is validated against `core.https_address` and it is made sure, that the necessary configurations are taken, namely `core.https_address` and `cluster.https_address` if necessary. After everything is checked and put in the correct state, it is save to use the address from the join request for the subsequent operations. Signed-off-by: Lucas Bremgartner <lucas.bremgartner@futurfusion.io>
If cluster.https_address has been previously configured, the server address provided with the cluster join request should be verified against this address. If the two address do not match, this is an error. Signed-off-by: Lucas Bremgartner <lucas.bremgartner@futurfusion.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See FuturFusion/operations-center#136 (comment) for details.
I am pretty sure, that we need the fix from the first commit. The second commit might be debatable.