Skip to content

incusd/instance/qemu: Fix memory calculation logic #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

incusd/instance/qemu: Fix memory calculation logic #2240

merged 1 commit into from
Jul 2, 2025

Conversation

stgraber
Copy link
Member

@stgraber stgraber commented Jul 2, 2025

This fixes another issue with the logic where a system with no detected physical bits would cause a 0 value which would then be decreased, leading to the maximum value possible of 1TB.

@stgraber
incusd/instance/qemu: Fix memory calculation logic
60c8f08 
This fixes another issue with the logic where a system with no detected
physical bits would cause a 0 value which would then be decreased,
leading to the maximum value possible of 1TB.

Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
@hallyn hallyn enabled auto-merge July 2, 2025 18:12
@hallyn hallyn merged commit 07baf74 into lxc:main Jul 2, 2025
71 of 72 checks passed
@cemzafer
Copy link

cemzafer commented Jul 5, 2025 •
edited
Loading

Sorry to disturb your time, I suppose the following error related with this case.
ubuntu@tnode1:~$ uname -a
Linux tnode1 6.1.0-1025-rockchip #25-Ubuntu SMP Mon Aug 26 23:01:14 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

ubuntu@tnode1:~$ incus launch images:ubuntu/24.04 --vm test
Launching test
Error: Failed instance creation: Failed to run: forklimits limit=memlock:unlimited:unlimited fd=3 fd=4 -- /opt/incus/bin/qemu-system-aarch64 -S -name test -uuid 4d27b082-798b-45a3-a40b-0814a2789dc1 -daemonize -cpu host -nographic -serial chardev:console -nodefaults -no-user-config -sandbox on,obsolete=deny,elevateprivileges=allow,spawn=allow,resourcecontrol=deny -readconfig /run/incus/test/qemu.conf -spice unix=on,disable-ticketing=on,addr=/run/incus/test/qemu.spice -pidfile /run/incus/test/qemu.pid -D /var/log/incus/test/qemu.log -rtc base=2025-07-05T14:59:22 -smbios type=2,manufacturer=LinuxContainers,product=Incus -runas incus: : exit status 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallyn hallyn hallyn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stgraber @cemzafer @hallyn