Skip to content

Feature: Added support for "physical" interface with bridge as parent #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Feature: Added support for "physical" interface with bridge as parent #2130

merged 2 commits into from
Jun 4, 2025

Conversation

NathanChase22
Copy link
Contributor

fixes #1735

After checking if parent property points to a bridge network, we create and instantiate a bridged device which we use to call Start() and Stop().

Meaning we are using 'bridged' logic already implemented, avoiding attempts to attach the parent interface into the container namespace which was the cause of previous errors.

This is the log showing success in launching a container following these steps :

Name: c1
Description: 
Status: RUNNING
Type: container
Architecture: x86_64
PID: 270002
Created: 2025/05/20 22:48 UTC
Last Used: 2025/05/20 23:26 UTC
Started: 2025/05/20 23:26 UTC

Resources:
  Processes: 10
  CPU usage:
    CPU usage (in seconds): 0
  Memory usage:
    Memory (current): 20.75MiB
  Network usage:
    eth0:
      Type: broadcast
      State: UP
      Host interface: veth57af7d0c
      MAC address: 32:da:df:6b:fc:d6
      MTU: 1500
      Bytes received: 300B
      Bytes sent: 904B
      Packets received: 2
      Packets sent: 5
      IP addresses:
        inet6: fe80::a046:6bff:fe0a:156d/64 (link)
    lo:
      Type: loopback
      State: UP
      MTU: 65536
      Bytes received: 0B
      Bytes sent: 0B
      Packets received: 0
      Packets sent: 0
      IP addresses:
        inet:  127.0.0.1/8 (local)
        inet6: ::1/128 (local)

@NathanChase22 NathanChase22 requested a review from stgraber as a code owner May 20, 2025 23:40
@NathanChase22 NathanChase22 marked this pull request as draft May 21, 2025 22:03
@NathanChase22 NathanChase22 marked this pull request as ready for review May 22, 2025 19:51
@stgraber stgraber added this to the incus-6.14 milestone May 29, 2025
@NathanChase22
Copy link
Contributor Author

Both tests failed at the setup stage, is it possible to rerun?

@stgraber
Copy link
Member

Not worth re-running since I'll most likely be making a few changes to this PR before merging it. I just ran out of time before the Incus 6.13 release, but I'll be looking at the remaining open PRs over the next few days.

@NathanChase22
Copy link
Contributor Author

Not worth re-running since I'll most likely be making a few changes to this PR before merging it. I just ran out of time before the Incus 6.13 release, but I'll be looking at the remaining open PRs over the next few days.

What sort of changes do you have in mind?

@stgraber
Copy link
Member

What sort of changes do you have in mind?

I usually always do a full rebase and cleanup of the commit list to re-title things a bit.
In some cases I also need to allocate an API extension string, though I don't think it will be required here. Then there are usually a few minor cosmetic things (comment messages, variable naming, ...) which I may be tweaking before merging.

@NathanChase22 @stgraber
incusd/device/nic_physical: Check for parent being a bridge
4e1400c 
Signed-off-by: Nathan Chase <ntc477@utexas.edu>
@NathanChase22 @stgraber
incusd/device/nic_physical: Handle managed physical network being a b…
16a276a 
…ridge

Closes lxc#1735

Signed-off-by: Nathan Chase <ntc477@utexas.edu>
@stgraber stgraber force-pushed the simplifiied-bridge-as-parent branch from d420f5b to 16a276a Compare June 4, 2025 02:07
@stgraber stgraber enabled auto-merge June 4, 2025 02:08
@stgraber stgraber merged commit 07452f7 into lxc:main Jun 4, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
incus-6.14
Development

Successfully merging this pull request may close these issues.

Support attaching instances to a "physical" network that's using a bridge as parent
2 participants
@NathanChase22 @stgraber