Allow for direct S3 push of instance and custom volume backups #2067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stgraber Apologies for the multiple comments. We were hoping you could review the pull request when you have a moment, so we can address any issues in our implementation if needed. Thank you very much for your time! |
|
@parthgupta2005 no worries. I'm going through the PRs mostly in notification order from Github. There's quite a lot to look at but hopefully I can clear my backlog tomorrow or Thursday. |
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
c5b50a7 to
0e6d4c0
Compare
stgraber
approved these changes
Jun 3, 2025
|
Sorry for the delay. I ended up doing a bit of tweaking on this one to make it easier to use and more flexible in the future. |
0e6d4c0 to
5ba6360
Compare
Signed-off-by: Akshat Kumar <akaman.boss@gmail.com>
Signed-off-by: Akshat Kumar <akaman.boss@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Akshat Kumar <akaman.boss@gmail.com>
5ba6360 to
165a112
Compare
stgraber
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended backup APIs to support uploading instance and custom volume backups to an S3 bucket, deleting the local backup afterwards.