Skip to content

Fix behavior when ACL name is used as match source #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2025
Merged

Fix behavior when ACL name is used as match source #2433

merged 2 commits into from
Aug 28, 2025

Conversation

presztak
Copy link
Collaborator

#2372 introduced a bug that causes incorrect behavior when an ACL name is used as a source.
Previously, the match expression was generated in the following format:

(outport == @incus_acl13_ingress_reversed) &&
(inport == @incus_acl13_ingress ||
 inport == @incus_acl13_ingress_reversed ||
 inport == @incus_acl13_egress ||
 inport == @incus_acl13_egress_reversed)

However, this fails if any of the port groups are empty, since OVN does not copy empty port groups between the Northbound and Southbound databases. This results in a parsing error in the match expression.

This PR introduces a new port group that aggregates all ports assigned to the ACL, ensuring the match expression remains valid

@presztak
incusd/network/ovn: Fix behavior when ACL name is used as match source
77881bc 
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
@presztak
incusd/network/acl: Fix behavior when ACL name is used as match source
0b9c1dc 
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
@presztak presztak force-pushed the ovn_source_acl_fix branch from d04d406 to 0b9c1dc Compare August 28, 2025 16:13
@presztak presztak marked this pull request as ready for review August 28, 2025 17:21
@presztak presztak requested a review from stgraber as a code owner August 28, 2025 17:21
@stgraber stgraber merged commit 2c25dbe into lxc:main Aug 28, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber Awaiting requested review from stgraber stgraber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@presztak @stgraber