incus/internal/server/device/nic_routed.go: Added host_tables #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signed-off-by: Avi Patel <avipatel805@gmail.com>
|
@AbhinavTiruvee needs a rebase / conflict resolution following #1956 having gotten merged earlier today |
Signed-off-by: Abhinav Tiruveedhula <122314438+AbhinavTiruvee@users.noreply.github.com>
|
@stgraber, my partner and I are having some trouble running the test suite for this change. We have a clean Ubuntu VM with incus set up according to these instructions #1801 (comment), except replacing root with our home directory. The commands all work until we get to the test suite, when it tells us we need to run it through root. When doing that however, we keep getting dependency errors that we haven't been able to solve. Can you help us with this? |
For now we're requiring equivalent permissions to full admin on Incus. Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Nathan Chase <ntc477@utexas.edu>
Signed-off-by: Nathan Chase <ntc477@utexas.edu>
Signed-off-by: Nathan Chase <ntc477@utexas.edu>
I've wanted to copy paste this a couple of times, but it's a little inconvenient because of the placeholder. Replace it with a standard environment variable (looks like it's part of POSIX). Signed-off-by: Brendan Jackman <jackmanb@google.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Closes: lxc#1921 Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Closes: lxc#1917 Signed-off-by: Benjamin Somers <benjamin.somers@imt-atlantique.fr>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Tony Nguyen <tonynguyen10@utexas.edu>
Signed-off-by: Tony Nguyen <tonynguyen10@utexas.edu>
Signed-off-by: Tony Nguyen <tonynguyen10@utexas.edu>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
…support Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
AddHandler is checking if the listener is not nil before starting it. However, when the last handler is removed, the listener could be set to nil asynchronously in a goroutine. If a new handler was added immediately after, there was a chance the listener would never be started again, leading to dropped events. This fix ensures that the listener is properly restarted in such cases. Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io>
Signed-off-by: Saahir Narang <saahir.narang@gmail.com>
Signed-off-by: Saahir Narang <saahir.narang@gmail.com>
Signed-off-by: Saahir Narang <saahir.narang@gmail.com>
Since we're going to be throwing the generated data to nftables anyway, we don't need to be too careful about extra line breaks. But the current logic of removing line breaks just about everywhere would cause the occasional valid rule to be merged with a comment, making it disappear... Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
This aligns the behavior with OVN where the most basic connectivity for the purpose of obtaining IP addresses and DNS should be allowed. Closes lxc#1919 Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Rahaf Aljerwi <aljerwi.rahaf@yahoo.com>
Signed-off-by: Rahaf Aljerwi <aljerwi.rahaf@yahoo.com>
Signed-off-by: Rahaf Aljerwi <aljerwi.rahaf@yahoo.com>
Signed-off-by: Rahaf Aljerwi <aljerwi.rahaf@yahoo.com>
Signed-off-by: Rahaf Aljerwi <aljerwi.rahaf@yahoo.com>
Signed-off-by: Ahmet F. Turhan <afaturhan@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Package `github.com/syndtr/gocapability` has stayed for long time without update or bug fix, and Incus uses little function it provides. Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
signed-off-by: Avi Patel <avipatel805@gmail.com>
signed-off-by: Avi Patel <avipatel805@gmail.com>
signed-off-by: Avi Patel <avipatel805@gmail.com>
signed-off-by: Avi Patel <avipatel805@gmail.com>
Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Closes lxc#1966 Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org>
Signed-off-by: Lucas Bremgartner <lucas.bremgartner@futurfusion.io>
Signed-off-by: Stéphane Graber <stgraber@stgraber.org> Sponsored-by: https://webdock.io
…t for the logfile path Signed-off-by: Gwendolyn <me@gwendolyn.dev>
Signed-off-by: Gwendolyn <me@gwendolyn.dev>
Signed-off-by: Gwendolyn <me@gwendolyn.dev>
…ee/incus into RoutedNICHostTables
|
Closing this PR and opening a new one due to it being pretty outdated from when we started, so many more commits were added than is required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on specifying which tables routes can go, would appreciate any tips/pointers.
(#1559)