Update to qemu 5.1 #20
Conversation
|
The resize to 2GB is only going to work with the Lite image by the look of things |
|
And it will need to check the size of a passed in image as well for the VM only build. |
Also include changes needed for Qemu 5.1 from lukechilds#20 as needed for USB support. Device comes up as usb0 but close enough to get started
| @@ -89,8 +90,8 @@ ENTRYPOINT ["./entrypoint.sh"] | |||
| # It's just the VM image with a compressed Raspbian filesystem added | |||
| FROM dockerpi-vm as dockerpi | |||
| LABEL maintainer="Luke Childs <lukechilds123@gmail.com>" | |||
| ARG FILESYSTEM_IMAGE_URL="http://downloads.raspberrypi.org/raspbian_lite/images/raspbian_lite-2019-09-30/2019-09-26-raspbian-buster-lite.zip" | |||
| ARG FILESYSTEM_IMAGE_CHECKSUM="a50237c2f718bd8d806b96df5b9d2174ce8b789eda1f03434ed2213bbca6c6ff" | |||
| ARG FILESYSTEM_IMAGE_URL="http://downloads.raspberrypi.org/raspbian_lite/images/raspbian_lite-2020-02-14/2020-02-13-raspbian-buster-lite.zip" | |||
There was a problem hiding this comment.
I'm assuming this change isn't required to update to QEMU 5.1? If so, best to update the image in a separate PR.
There was a problem hiding this comment.
No, but given how old the previous image was it made sense to move up as well.
| @@ -10,6 +10,8 @@ if [ ! -e $image_path ]; then | |||
| echo "Extracting fresh filesystem..." | |||
| unzip $zip_path | |||
| mv -- *.img $image_path | |||
|
|
|||
| qemu-img resize $image_path 2G | |||
There was a problem hiding this comment.
What is the reasoning behind this? Just to increase the filesystem size for normal use? Or is it required for QEMU 5.1?
If not required, it should be a separate PR.
There was a problem hiding this comment.
This is required for 64 bit based CPUs and is required for all at qemu 5.2
There was a problem hiding this comment.
Thanks!
So there's just a hard limit that all images must be no less that 2GB in size? Do you have source you could point me to so I can read more about that?
There was a problem hiding this comment.
It's been so long I can't remember if it's in the docs but I know it fails with an error message if you try with anything that is not a multiple of 2g
There was a problem hiding this comment.
Found it: mail-archive.com/qemu-devel@nongnu.org/msg723028.html
|
The other PR #21 is better suited to be merged as it adds all this and network support the Pi2 and Pi3 based systems and jumps straight to qemu 5.2 |
|
Yeah I've seen that PR, it looks great! However I prefer to keep PRs down to a single atomic change. So one change = one PR = one squashed commit merged into master. I've seen QEMU 6.0.0 is out so just testing that locally. Once that's merged it would be great to rebase #21 on to master just adding network support for the Pis without changing QEMU or Raspbian images. |
|
But 5.2 is needed for the network change, so nearly everything in the other PR is required |
|
Fair point, ok lets merge it as one PR then. |
|
Closed in favour of #21 |
No description provided.