Skip to content

Conversation

Azlond
Copy link
Contributor

@Azlond Azlond commented Dec 6, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
    • no, preexisting tests cover this behavior
  • This PR is associated with an existing issue?

Closing issues
closes #1714

Test plan

pre-existing tests cover the behavior without the new rewriteRelativeImportExtensions-setting, while I've added two new test cases for .ts-files and .mts-files with the new setting enabled.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there Azlond 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@WoH WoH force-pushed the master branch 2 times, most recently from 30cc104 to 82b61ec Compare December 8, 2024 16:44
@WoH WoH merged commit 9a09986 into lukeautry:master Dec 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TypeScript 5.7 "rewriteRelativeImportExtensions" option
2 participants