Skip to content

Fix incompatibility with latest InversifyJS #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 8, 2024
Merged

Fix incompatibility with latest InversifyJS #1718

merged 6 commits into from
Dec 8, 2024

Conversation

helios-ag
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #1717

github-actions[bot]
github-actions bot reviewed Nov 18, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there helios-ag 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@helios-ag
Copy link
Contributor Author

@WoH @jackey8616 bump

@amt8u
Copy link

amt8u commented Nov 25, 2024

@dgreene1 @lukeautry bump. The PR is open for sometime now.

@helios-ag
Copy link
Contributor Author

A bit weird, that GHA fails...

@helios-ag
Copy link
Contributor Author

@WoH bump

WoH
WoH approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@WoH WoH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at who broke types upstream & why separately. LGTM

@helios-ag
Copy link
Contributor Author

@WoH bump

@WoH
Copy link
Collaborator

WoH commented Dec 6, 2024

I'll fix Base over the weekend and promise to get this over the finish line.
Sorry for the delays, I had personal stuff taking priority.

@WoH WoH merged commit f2f666e into lukeautry:master Dec 8, 2024
1 of 19 checks passed
@helios-ag
Copy link
Contributor Author

Thanks @WoH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@WoH WoH WoH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility with recent versions of inversifyJS
4 participants
@helios-ag @amt8u @WoH @nuKs