[New Solver] fails to report type errors when using if-then-else expressions #1815
Description
Minimal repro:
--!strict
local item: "foo" = "bar" -- TypeError: Type '"bar"' could not be converted into '"foo"', good!
item = if true then "foo" else "foo" -- TypeError: Type 'string' could not be converted into '"foo"', bad!
local item2: "foo" = if true then "doge" else "doge2" -- no error, bad!There's two issues here:
- On line 2, the solver expands from the singletons to the generic
stringtype which causes assignment issues - On line 4 (and the main title of this issue), the solver does not report any errors! Based on line 1, this should report an error.