fix(icons): changed umbrella icon
#3490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsPreview cohesion      Preview stroke widths    DPI Preview16px (shadcn/ui) 
24px (default) 
32px (shadcn/ui + retina) 
48px (default + retina) 
Icon X-rays 
Icon Diffs 
Icons as codeWorks for: const UmbrellaOffIcon = createLucideIcon('UmbrellaOff', [
["path",{"d":"M12 13v7a2 2 0 0 0 4 0"}],
["path",{"d":"M12 2v2"}],
["path",{"d":"M18.656 13h2.336a1 1 0 0 0 .97-1.274 10.284 10.284 0 0 0-12.07-7.51"}],
["path",{"d":"m2 2 20 20"}],
["path",{"d":"M5.961 5.957a10.28 10.28 0 0 0-3.922 5.769A1 1 0 0 0 3 13h10"}]
])
const UmbrellaIcon = createLucideIcon('Umbrella', [
["path",{"d":"M12 13v7a2 2 0 0 0 4 0"}],
["path",{"d":"M12 2v2"}],
["path",{"d":"M20.992 13a1 1 0 0 0 .97-1.274 10.284 10.284 0 0 0-19.923 0A1 1 0 0 0 3 13z"}]
]) |
|
@jguddas, @ericfennis: TBH the alternate designs feel much better to me centre-of-gravity-wise, but they're a bigger change, and the same offset doesn't work well at all with the current design. |
|
The wavy variant looks super cute. |
|
But the wave is not very visible on 100% scale, making it a bit visually blurry. |
|
I agree with both of you. Maybe 1px down still is the way to go? Initially, it felt off, but maybe just because I was used to the current one, now I definitely feel like the second one is more optically centred. |
jguddas
approved these changes
Aug 4, 2025
ericfennis
approved these changes
Aug 8, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Arcified umbrella, fixed off-grid paths
Alternate design
Open lucide studio
Open lucide studio
Before Submitting