fix(icons): changed school icon
#2968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsPreview cohesion   Preview stroke widths  DPI Preview16px (shadcn/ui)
24px (default)
32px (shadcn/ui + retina)
48px (default + retina)
Icon X-rays
Icon Diffs
Icons as codeWorks for: const SchoolIcon = createLucideIcon('School', [
["path",{"d":"M14 21v-3a2 2 0 0 0-4 0v3"}],
["path",{"d":"M18 5v16"}],
["path",{"d":"m4 6 7.106-3.79a2 2 0 0 1 1.788 0L20 6"}],
["path",{"d":"m6 11-3.52 2.147a1 1 0 0 0-.48.854V19a2 2 0 0 0 2 2h16a2 2 0 0 0 2-2v-5a1 1 0 0 0-.48-.853L18 11"}],
["path",{"d":"M6 5v16"}],
["circle",{"cx":"12","cy":"9","r":"2"}]
]) |
jguddas
reviewed
Jul 21, 2025
I see what you mean, but with the roof I think it's nowhere near as bad as #2971 was. |
|
I see what @jguddas means 😅. |
|
@ericfennis @jguddas We could maybe just decrease the height by 1px then, similarly as it currently is in |
3 tasks
ericfennis
approved these changes
Jul 31, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
Fixed design guideline violations
Before Submitting