Skip to content

Using fork() on Ctrl+Enter #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2022
Merged

Using fork() on Ctrl+Enter #133

merged 4 commits into from
Oct 24, 2022

Conversation

geekylthyosaur
Copy link
Contributor

Close #24.
I've looked through the code and found that using fork() right before execvp*() requires replacing exec() return type std::convert::Infallible with something else. So, instead I use fork() right after Ctrl+Enter was detected.

l4l
l4l reviewed Oct 24, 2022
View reviewed changes
Copy link
Owner

@l4l l4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using fork() right before execvp*() requires replacing exec() return type .. instead I use fork() right after Ctrl+Enter was detected

That's a way better approach otherwise fork logic need to be duplicated in each Mode.

--

Overall looks good to me

@l4l l4l enabled auto-merge (squash) October 24, 2022 11:44
@l4l l4l merged commit e71aa55 into l4l:master Oct 24, 2022
@l4l
Copy link
Owner

l4l commented Oct 24, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l4l l4l l4l left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ctrl+enter hotkey for fork then exec
2 participants
@geekylthyosaur @l4l