Skip to content

Build support + address sanitizer check #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 30, 2023
Merged

Build support + address sanitizer check #117

merged 11 commits into from
Dec 30, 2023

Conversation

krupkat
Copy link
Owner

@krupkat krupkat commented Dec 30, 2023 •
edited
Loading

Bunch of changes for a smoother build process with the provided scripts in the misc directory:

  • Fix building with exiv2 >= 0.28.0
    • v 0.28.1 is using Exiv2::exiv2lib target vs the previous exiv2lib target
    • version checking with find_package wasn't working, had to switch to VERSION_GREATER_EQUAL
  • Added nix-shell dev environments, default.nix and asan.nix
    • Fixed memory leak in resource::LoadIcon
  • Updated dependencies
    • exiv2 0.28.1
    • nfde 1.1.1
    • catch2 3.5.0
  • switched to find_package CONFIG mode everywhere for consistency and more modern approach

@krupkat krupkat changed the title Build support Build support + address sanitizer check Dec 30, 2023
@krupkat krupkat merged commit 72b4917 into main Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krupkat