Skip to content

Enable getting a user by their federated IdP UID #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Enable getting a user by their federated IdP UID #1003

merged 1 commit into from
Jun 14, 2025

Conversation

jeromegamez
Copy link
Member

This is based on and replaces #1000 with the following changes/additions:

  • Changed tests so they run within the emulator test suite and not in the integration test suite
    • This allows for a happy path and an unhappy path test
    • Instead of using a dummy IdP, the real™/emulated phone IdP can be used
  • Updated documentation and changelog

Thank you @mkilmanas for the great work and collaboration in #1000, the commit of this PR is attributed to us both!

:octocat:

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.49%. Comparing base (00f2564) to head (bdc2bb9).
Report is 4 commits behind head on 7.x.

❗ There is a different number of reports uploaded between BASE (00f2564) and HEAD (bdc2bb9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (00f2564) HEAD (bdc2bb9)
integration 1 0
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                7.x    #1003       +/-   ##
=============================================
- Coverage     90.02%   71.49%   -18.54%     
- Complexity     1443     1446        +3     
=============================================
  Files           140      140               
  Lines          4192     4203       +11     
=============================================
- Hits           3774     3005      -769     
- Misses          418     1198      +780
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromegamez jeromegamez mentioned this pull request Jun 5, 2025
Closed
@jeromegamez jeromegamez force-pushed the federated-user-fetcher branch from 39f15b1 to 36e08b4 Compare June 5, 2025 22:10
@jeromegamez jeromegamez force-pushed the federated-user-fetcher branch from 36e08b4 to ade41a6 Compare June 14, 2025 13:42
@jeromegamez @mkilmanas
Enable getting a user by their federated IdP UID
bdc2bb9 
Co-authored-by: Marijus Kilmanas <marijus.kilmanas@visiongroup.io>
@jeromegamez jeromegamez force-pushed the federated-user-fetcher branch from ade41a6 to bdc2bb9 Compare June 14, 2025 13:43
@jeromegamez jeromegamez merged commit 15e63f2 into 7.x Jun 14, 2025
13 of 14 checks passed
@jeromegamez jeromegamez deleted the federated-user-fetcher branch June 14, 2025 21:33
@mkilmanas
Copy link
Contributor

Hey @jeromegamez - thanks for pushing this though the finish line. However, I see that this PR was merged 1 day after the latest release was tagged. Are there any plans when the next release might get tagged? Still waiting for this functionality to become publicly available 😄

@jeromegamez
Copy link
Member Author

Shoot, I thought I did! I will create a new release later today!

@jeromegamez
Copy link
Member Author

Have I mentioned that my days have 48h and that's why you think I'm late but I'm actually not! 😅

Anyway, at last, the release is here: https://github.com/kreait/firebase-php/releases/tag/7.20.0

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromegamez @mkilmanas