Add and address PHPStan strict rules #1006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeromegamez
commented
Jun 16, 2025
While refactoring the Auth class, I wanted to add a method to get the first user record of an `/accounts:lookUp` API call. I noticed that there already was a `getUserRecordFromResponse()` method, but it was related to responses after calls to other API endpoints. Renaming it to `getUserRecordFromResponseAfterUserUpdate()` makes the intent clearer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.x #1006 +/- ##
=============================================
- Coverage 90.05% 71.60% -18.45%
- Complexity 1446 1455 +9
=============================================
Files 140 140
Lines 4203 4258 +55
=============================================
- Hits 3785 3049 -736
- Misses 418 1209 +791 🚀 New features to boost your workflow:
|
|
Failing tests are flaky :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.