Fix PR_SET_CHILD_SUBREAPER call #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR_SET_CHILD_SUBREAPER actually requires a non-zero argument to `prctl` in order to work..! Now, this used to work just fine (and currently works in most places) because when we use a libc that doesn't know about PR_SET_CHILD_SUBREAPER, it doesn't do anything about the second argument passed to `pctrl`, so we end up sending some junk in as the second argument. What we send appears to be completely random and as such seems very unlikely to be zero, and so things appear to work (e.g. the tests all pass, etc.). However, using a libc that does know about this argument (e.g. Ubuntu Xenial), things *don't* work because the second argument is automatically set to 0 when we don't provide one. This probably went unnoticed for a while considering that `tini-static` isn't affected (it's built on Trusty), and that this mode isn't enabled by default in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR_SET_CHILD_SUBREAPER actually requires a non-zero argument to
prctlin order to work..!
Now, this used to work just fine (and currently works in most places)
because when we use a libc that doesn't know about
PR_SET_CHILD_SUBREAPER, it doesn't do anything about the second argument
passed to
pctrl, so we end up sending some junk in as the secondargument. What we send appears to be completely random and as such seems
very unlikely to be zero, and so things appear to work (e.g. the tests
all pass, etc.).
However, using a libc that does know about this argument (e.g. Ubuntu
Xenial), things don't work because the second argument is
automatically set to 0 when we don't provide one.
This probably went unnoticed for a while considering that
tini-staticisn't affected (it's built on Trusty), and that this mode isn't enabled
by default in the first place.