Skip to content

Conversation

Reanon
Copy link
Contributor

@Reanon Reanon commented Nov 28, 2022

  1. Implement stack & queue in array.
  2. Implement stack & queue in linkedlist.
    3.Add testcase & benchmark in stack & queue.

@vercel
Copy link

vercel bot commented Nov 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
hello-algo ⬜️ Ignored (Inspect) Nov 29, 2022 at 2:48AM (UTC)

package chapter_stack_and_queue

import "testing"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing for the Go built-in stack is required.


package chapter_stack_and_queue

type Deque interface {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing for the Go built-in deque is required.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use interface to reveal the usage of built-in Stack, Queue, and Deque?
I'm wondering if it is the only way as It is not consistent with other languages.

Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean code, @Reanon! Some comments need to be addressed.

@Reanon Reanon force-pushed the feature/support-go-chapter-stack-queue branch from dc2e043 to a554590 Compare November 29, 2022 02:47
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Reanon ! Now merge it.

@krahets krahets merged commit 225c96c into krahets:master Nov 29, 2022
@krahets krahets added the code Code-related label Dec 3, 2022
@Reanon Reanon changed the title Feature/support go chapter stack queue feat(stack_and_queue): add go code. Jan 8, 2023
@Reanon Reanon mentioned this pull request Jan 8, 2023
36 tasks
@Reanon Reanon deleted the feature/support-go-chapter-stack-queue branch January 9, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants