Centralize all assertion handling into AssertionErrorBuilder. #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This avoids the myriad of functions we had scattered about that created error messages used by assertion errors. * Propagates opentest4j comparison errors properly to team city output to show diffs in all contexts * Adds KMP handling for comparison errors * Moves all the non-shared assertions/helpers into the assertions core module, leaving the namespace unpolluted for anyone not using kotest assertions * Unifies types into the Printed typeclass. No custom plugin mechansim exists for Printed typeclasses, so it's safe to make breaking changes * Move the long defunct table testing code into its own module and deprecate it all
* This avoids the myriad of functions we had scattered about that created error messages used by assertion errors. * Propagates opentest4j comparison errors properly to team city output to show diffs in all contexts * Adds KMP handling for comparison errors * Moves all the non-shared assertions/helpers into the assertions core module, leaving the namespace unpolluted for anyone not using kotest assertions * Unifies types into the Printed typeclass. No custom plugin mechansim exists for Printed typeclasses, so it's safe to make breaking changes * Move the long defunct table testing code into its own module and deprecate it all
* This avoids the myriad of functions we had scattered about that created error messages used by assertion errors. * Propagates opentest4j comparison errors properly to team city output to show diffs in all contexts * Adds KMP handling for comparison errors * Moves all the non-shared assertions/helpers into the assertions core module, leaving the namespace unpolluted for anyone not using kotest assertions * Unifies types into the Printed typeclass. No custom plugin mechansim exists for Printed typeclasses, so it's safe to make breaking changes * Move the long defunct table testing code into its own module and deprecate it all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize all assertion handling into AssertionErrorBuilder.