Skip to content

Conversation

sksamuel
Copy link
Member

@sksamuel sksamuel commented Jul 26, 2025

This setsup WASM wasi publishing for the modules required by the WASM wasi plugins.

@sksamuel sksamuel requested a review from a team as a code owner July 26, 2025 01:39
@sksamuel sksamuel merged commit 1b3649c into master Jul 26, 2025
7 checks passed
@sksamuel sksamuel deleted the sks/setup-wasm branch July 26, 2025 06:19
group("jsHosted") {
withJs()
withWasmJs()
withWasmWasi()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that work? Wasm/WASI is not a JS-hosted platform in the sense that a JS API is available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably depends on whether you are actually using JS APIs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that work? Wasm/WASI is not a JS-hosted platform in the sense that a JS API is available.

I was just copying what was already there. I thought you had set it up actually. I know next to nothing about wasm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was me who introduced the "jsHosted" group for targets using the JS API. This means Kotlin/JS and Kotlin/Wasm/JS. Kotlin/Wasm/WASI does not have any JS API access, so it should not be in that group. WASI is a completely different runtime with its own set of APIs.

What can be irritating is that there are runtimes like Node.js, which came from the JS world, but can now also run Wasm applications with a purely WASI API. (There are lots of other Wasm/WASI runtimes, which have have no no JS origins at all.)

So we need to take care of the situation when JS APIs are not available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed jsHosted now and added nonjvm as a group, which results in less boilerplate, as most of the implementations boil down to JVM vs not-JVM, with a few wasm specific things I just left in wasmJs or wasmWasi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants