-
Notifications
You must be signed in to change notification settings - Fork 679
Compiler assertions improvements #4874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AlexCue987
merged 11 commits into
kotest:master
from
0x746143:compiler-assert-improvements
May 14, 2025
Merged
Compiler assertions improvements #4874
AlexCue987
merged 11 commits into
kotest:master
from
0x746143:compiler-assert-improvements
May 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0x746143
commented
May 13, 2025
- syntax highlighted code snippet
- code snipped with inline functions
- checking a compilation error message
- custom assertions on JvmCompilationResult
- custom compiler configuration (compiler plugin, jvmTarget, etc.)
… to resolve the error "Cannot inline bytecode built with JVM target 11 into bytecode that is being built with JVM target 1.8"
…mCompilationResult in tests
…fter compiling CodeSnippet
- use a syntax highlighted code snippet - check a compilation error message - compile an inline function - fine-grained assertions on JvmCompilationResult - use a Kotlin compiler plugin
- Remove unnecessary trimIndent() - Fix a variable name - Improve readability
…pet, CompileConfig, and compile helper
AlexCue987
reviewed
May 13, 2025
afc16b6
to
eecbef8
Compare
AlexCue987
approved these changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.