Skip to content

Enabling tests on macOS, unless we are running CI #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 30, 2025
Merged

Enabling tests on macOS, unless we are running CI #4818

merged 8 commits into from
Mar 30, 2025

Conversation

Kantis
Copy link
Member

@Kantis Kantis commented Mar 21, 2025

No description provided.

@Kantis Kantis force-pushed the kantis/not-mac-on-github-condition branch from aec2ecd to e188914 Compare March 21, 2025 21:00
@sksamuel sksamuel marked this pull request as ready for review March 29, 2025 20:58
@sksamuel sksamuel requested a review from a team as a code owner March 29, 2025 20:58
@sksamuel sksamuel enabled auto-merge March 29, 2025 20:58
sksamuel
sksamuel approved these changes Mar 29, 2025
View reviewed changes
Copy link
Member

@sksamuel sksamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, gonna push this over the line as its really useful

@sksamuel sksamuel added this pull request to the merge queue Mar 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 30, 2025
@sksamuel sksamuel added this pull request to the merge queue Mar 30, 2025
Merged via the queue into master with commit f100b05 Mar 30, 2025
7 checks passed
@sksamuel sksamuel deleted the kantis/not-mac-on-github-condition branch March 30, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kantis @sksamuel