Skip to content

add Arb.plusEdgecases #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2025
Merged

add Arb.plusEdgecases #4803

merged 4 commits into from
Mar 9, 2025

Conversation

AlexCue987
Copy link
Member

example:

val intArb = Arb.Companion.int(-50..50)
val edgecases = intArb.edgecases().toList()
val additionalEdgecases = listOf(-42, 42)
val newEdgecases = intArb.plusEdgecases(additionalEdgecases).edgecases().toList()
newEdgecases.containsAll(edgecases) shouldBe true
newEdgecases.containsAll(additionalEdgecases) shouldBe true

@AlexCue987 AlexCue987 requested a review from a team as a code owner March 7, 2025 22:02
LeoColman
LeoColman reviewed Mar 9, 2025
View reviewed changes
kotest-property/src/jvmTest/kotlin/com/sksamuel/kotest/property/arbitrary/PlusEdgecasesTest.kt Outdated
Comment on lines 21 to 22
newEdgecases.containsAll(edgecases) shouldBe true
newEdgecases.containsAll(additionalEdgecases) shouldBe true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:
We should have an assertion that original edgeCases do not contain all edge cases. Otherwise we could be just proxying withEdgeCases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We should have an assertion that original edgeCases do not contain all edge cases. Otherwise we could be just proxying withEdgeCases

good catch, added an assertion

@AlexCue987 AlexCue987 added this pull request to the merge queue Mar 9, 2025
Merged via the queue into master with commit c673dcf Mar 9, 2025
7 checks passed
@AlexCue987 AlexCue987 deleted the alex/plusEdgecases branch March 9, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColman LeoColman LeoColman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexCue987 @LeoColman